Incomplete deletion of related data when deleting #1415

Activity

1. DylanovE commented on Apr 13, 2023

   

   DylanovE

   on Apr 13, 2023

   Author

   More actions

   i've tried changing the code for myself but its a puzzle i cant seem to solve hence i made the issue..
   it never destroys documents dependant on the dependant documents.
   this is the destroy code:
   ` function destroy(req, res, next) {
   let resource;

   if (opts._isFake) {
     resource = db.get(name).value();
   } else {
     resource = db.get(name).removeById(req.params.id).value(); // Remove dependents documents
   
     const removable = db._.getRemovable(db.getState(), opts);
   
     removable.forEach(item => {
       db.get(item.name).removeById(item.id).value();
     });
   }
   
   if (resource) {
     res.locals.data = {};
   }
   
   next();
   

   }`
2. MadhuSaini22 commented on Dec 26, 2023

   

   MadhuSaini22

   on Dec 26, 2023

   More actions

   It seems like you're facing an issue where deleting a village doesn't automatically delete related houses and citizens. To achieve this cascading deletion, you may need to implement a custom logic to handle dependent resources.

   Here's a modification to your existing code:
   function destroy(req, res, next) {
   const villageId = parseInt(req.params.id);

   // Remove houses associated with the village
   db.get("houses").remove({ villageId }).value();

   // Remove citizens associated with the houses
   db.get("citizens").remove((citizen) => {
   const house = db.get("houses").find({ id: citizen.houseId, villageId }).value();
   return house !== undefined;
   }).value();

   // Remove the village itself
   const removedVillage = db.get("villages").remove({ id: villageId }).value();

   if (removedVillage) {
   res.locals.data = {};
   }

   next();
   }

   This modification ensures that when a village is deleted, it first removes associated houses and then removes citizens associated with those houses. Finally, it removes the village itself.

   Please adjust the code based on your exact data structure and requirements. It's crucial to handle dependencies in the correct order to avoid inconsistencies.